Meilleurs messages postés par Bitfarmer

Forgive me if I am telling you something you already know, I am relatively new the PhenixSuite. While attempting to install 1.6.2.12 on a debian test machine I ran into two problems. I surely can't be the first to discover them. The first is caused but the use of an unescaped MySQL reserved word as a table name. The second by an unencoded & in the name of a TAB. I enclose the relevant patches below. Maybe I've been staring at code for too long, but on the other hand maybe it will help someone else!

diff a/install/classes/xmlLoader.php b/install/classes/xmlLoader.php
--- a/install/classes/xmlLoader.php	2023-02-13 13:54:58.000000000 +0000
+++ b/install/classes/xmlLoader.php	2023-07-16 13:30:51.764484508 +0000
@@ -578,7 +578,7 @@ class InstallXmlLoader
     public function generatePrimary($entity, $primary)
     {
         if (!isset($this->primaries[$entity])) {
-            $this->primaries[$entity] = (int)Db::getInstance()->getValue('SELECT '.$primary.' FROM '._DB_PREFIX_.$entity.' ORDER BY '.$primary.' DESC');
+            $this->primaries[$entity] = (int)Db::getInstance()->getValue('SELECT '.$primary.' FROM `'._DB_PREFIX_.$entity.'` ORDER BY '.$primary.' DESC');
         }
         return ++$this->primaries[$entity];
     }
diff a/install/langs/en/data/tab.xml b/install/langs/en/data/tab.xml
--- s/install/langs/en/data/tab.xml	2023-03-17 19:07:54.000000000 +0000
+++ b/install/langs/en/data/tab.xml	2023-07-16 12:02:23.991545234 +0000
@@ -75,7 +75,7 @@
   <tab id="Maintenance" name="Maintenance"/>
   <tab id="Geolocation" name="Geolocation"/>
   <tab id="Configuration_Information" name="Configuration Information"/>
-  <tab id="Performance" name="Performance & Security"/>
+  <tab id="Performance" name="Performance &amp; Security"/>
   <tab id="E-mail" name="E-mail"/>
   <tab id="Multistore" name="Multistore"/>
   <tab id="CSV_Import" name="CSV Import"/>

This is a deprecation error which won't show up on earlier versions of Python but does effect Python 8.1 up. The fix is very simple:

diff -wurp a/tools/swift/classes/Swift/Transport/AbstractSmtpTransport.php b/tools/swift/classes/Swift/Transport/AbstractSmtpTransport.php
--- a/tools/swift/classes/Swift/Transport/AbstractSmtpTransport.php	2023-09-27 21:04:32.000000000 +0000
+++ b/tools/swift/classes/Swift/Transport/AbstractSmtpTransport.php	2023-10-15 17:24:18.086451046 +0000
@@ -395,7 +395,7 @@ abstract class Swift_Transport_AbstractS
             do {
                 $line = $this->_buffer->readLine($seq);
                 $response .= $line;
-            } while (null !== $line && false !== $line && ' ' != $line{3});
+            } while (null !== $line && false !== $line && ' ' != $line[3]);
         } catch (Swift_TransportException $e) {
             $this->_throwException($e);
         } catch (Swift_IoException $e) {